Re-fetch help threads before closing#3228
Merged
Merged
Conversation
This ensures that the thread title is up-to-date. Previously, even if someone changed the title of the thread, the bot might prepend the lock emoji to an older version of the title.
Contributor
Author
|
|
ChrisLovering
approved these changes
Jan 4, 2025
| async def _close_help_post(closed_post: discord.Thread, closing_reason: _stats.ClosingReason) -> None: | ||
| """Close the help post and record stats.""" | ||
| # Get Thread with updated metadata (such as the title) | ||
| closed_post = await pydis_core.utils.channel.get_or_fetch_channel(bot.instance, closed_post.id) |
Member
There was a problem hiding this comment.
Suggested change
| closed_post = await pydis_core.utils.channel.get_or_fetch_channel(bot.instance, closed_post.id) | |
| closed_post = await get_or_fetch_channel(bot.instance, closed_post.id) |
Looks like get_or_fetch_channel is already imported in this file, so we can drop the import pydis_core entirely
ChrisLovering
temporarily deployed
to
production
GitHub Actions
Inactive
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This ensures that the thread title is up-to-date. Previously, even if someone changed the title of the thread, the bot might prepend the lock emoji to an older version of the title.